diff options
| author | levlam <levlam@telegram.org> | 2023-11-25 02:34:37 +0300 |
|---|---|---|
| committer | levlam <levlam@telegram.org> | 2023-11-25 02:34:37 +0300 |
| commit | 511483e12c1ce2e558d9f7a90573a46015319e5e (patch) | |
| tree | 54fa8482f67b294804af8648d6d3c525f9f404ed /tdnet | |
| parent | 0d363724e5f8ed735d53a9758f4b2e920f4ee488 (diff) | |
Fail HTTP request reading if unexpected end of data reached.
Diffstat (limited to 'tdnet')
| -rw-r--r-- | tdnet/td/net/HttpReader.cpp | 10 | ||||
| -rw-r--r-- | tdnet/td/net/HttpReader.h | 2 |
2 files changed, 12 insertions, 0 deletions
diff --git a/tdnet/td/net/HttpReader.cpp b/tdnet/td/net/HttpReader.cpp index 953495c1d..d479d28e1 100644 --- a/tdnet/td/net/HttpReader.cpp +++ b/tdnet/td/net/HttpReader.cpp @@ -43,6 +43,16 @@ Result<size_t> HttpReader::read_next(HttpQuery *query, bool can_be_slow) { CHECK(query_ == nullptr); query_ = query; } + + auto r_size = do_read_next(can_be_slow); + if (state_ != State::ReadHeaders && flow_sink_.is_ready() && r_size.is_ok() && r_size.ok() > 0) { + CHECK(flow_sink_.status().is_ok()); + return Status::Error(400, "Bad Request: unexpected end of request content"); + } + return r_size; +} + +Result<size_t> HttpReader::do_read_next(bool can_be_slow) { size_t need_size = input_->size() + 1; while (true) { if (state_ != State::ReadHeaders) { diff --git a/tdnet/td/net/HttpReader.h b/tdnet/td/net/HttpReader.h index 4c360435d..8f5be2a33 100644 --- a/tdnet/td/net/HttpReader.h +++ b/tdnet/td/net/HttpReader.h @@ -87,6 +87,8 @@ class HttpReader { string temp_file_name_; int64 file_size_ = 0; + Result<size_t> do_read_next(bool can_be_slow); + Result<size_t> split_header() TD_WARN_UNUSED_RESULT; void process_header(MutableSlice header_name, MutableSlice header_value); Result<bool> parse_multipart_form_data(bool can_be_slow) TD_WARN_UNUSED_RESULT; |
